Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a workflow test for Optimus using the dsde-pipelines workflow test infrastructure #861

Open
kbergin opened this issue Mar 25, 2020 · 2 comments

Comments

@kbergin
Copy link

kbergin commented Mar 25, 2020

To better allow for iterative testing of the Optimus pipeline, we want a workflow test that only runs optimus (vs running as an integration test) and validates the workflow output. Using the dsde-pipelines test framework provides a way to do this.

Why do it? To facilitate iterative development of Optimus
Where to start? In dsde-pipelines, subclass CromwellWorkflowTester and add a new environment to TestCromwellEnvironment
When is it done? A running workflow test that can be run using sbt run

Upstream dependencies: requires inputs, options to run Optimus
Downstream dependencies: Verify test output with scientific owner, store as truth data, create an Optimus validation WDL, add to nightly workflow test in jenkins. These can all be split into other tasks as necessary.

To solve the problem of cross-repo dependencies, the Optimus test can be written to assume that the skylab repo is checked out in a known relative location to the dsde-pipelines repo. If this repo isn't present the test will fail with an error.

┆Issue is synchronized with this Jira Dev Task

@kbergin
Copy link
Author

kbergin commented Mar 25, 2020

Of note, we’ve made Optimus testing data and it is being used by Hornet in their testing for the DCP. May be helpful re: upstream dependencies and storing truth data. Nick, Kishori, Rex, Saman would be good contacts for Q’s

@kbergin
Copy link
Author

kbergin commented Mar 25, 2020

Postponed because in the short term we are going to use the existing CI infrastructure in Skylab for the HCA pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant