Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen_replay_buffer_capacity VS demo_batch_size in tutorials code #847

Open
piteren opened this issue Apr 18, 2024 · 0 comments
Open

gen_replay_buffer_capacity VS demo_batch_size in tutorials code #847

piteren opened this issue Apr 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@piteren
Copy link

piteren commented Apr 18, 2024

In both tutorials: 3_train_gail.ipynb and 4_train_airl.ipynb
trainer demo_batch_size is higher than gen_replay_buffer_capacity, which produces gen_samples with many repetitions
(imitation/algorithms/adversarial/common.py #560 - e.g.for AIRL there are 2048 samples sampled from the buffer of size 512).
Is that intentional or a bug?

@piteren piteren added the bug Something isn't working label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant