Enhance string comparison and refactor methods

Updated .editorconfig to set performance and globalization diagnostics to warnings. Refactored methods in InflectorExtensions.cs to use generated regex and extension method format. Improved string comparison across multiple files using StringComparison.Ordinal, StringComparison.OrdinalIgnoreCase, and culture-specific comparisons. Introduced static CultureInfo objects for consistent cultural formatting. Enhanced code readability and maintainability.

Author: clairernovotny

src/.editorconfig

@@ -237,7 +237,8 @@ dotnet_diagnostic.CA2241.severity = error
 dotnet_diagnostic.CA2242.severity = error
 
 
-# Test Projects
+dotnet_analyzer_diagnostic.category-Performance.severity = warning
+dotnet_analyzer_diagnostic.category-Globalization.severity = warning
 
 # IDE0022: Use expression body for method
 dotnet_diagnostic.IDE0022.severity = silent

src/Humanizer/Bytes/ByteSize.cs

@@ -270,7 +270,7 @@ readonly string ToString(string? format, IFormatProvider? provider, bool toSymbo
 
         var formattedLargeWholeNumberValue = LargestWholeNumberValue.ToString(format, provider);
 
-        formattedLargeWholeNumberValue = formattedLargeWholeNumberValue.Equals(string.Empty)
+        formattedLargeWholeNumberValue = formattedLargeWholeNumberValue.Equals(string.Empty, StringComparison.Ordinal)
             ? "0"
             : formattedLargeWholeNumberValue;
 

src/Humanizer/InflectorExtensions.cs

@@ -28,22 +28,22 @@ public static partial class InflectorExtensions
 #if NET7_0_OR_GREATER
     [GeneratedRegex(@"(?:[ _-]+|^)([a-zA-Z])")]
     private static partial Regex PascalizeRegexGenerated();
-    
+
     private static Regex PascalizeRegex() => PascalizeRegexGenerated();
 
     [GeneratedRegex(@"([\p{Lu}]+)([\p{Lu}][\p{Ll}])")]
     private static partial Regex UnderscoreRegex1Generated();
-    
+
     private static Regex UnderscoreRegex1() => UnderscoreRegex1Generated();
 
     [GeneratedRegex(@"([\p{Ll}\d])([\p{Lu}])")]
     private static partial Regex UnderscoreRegex2Generated();
-    
+
     private static Regex UnderscoreRegex2() => UnderscoreRegex2Generated();
 
     [GeneratedRegex(@"[-\s]")]
     private static partial Regex UnderscoreRegex3Generated();
-    
+
     private static Regex UnderscoreRegex3() => UnderscoreRegex3Generated();
 #else
     private static readonly Regex PascalizeRegexField = new(@"(?:[ _-]+|^)([a-zA-Z])", RegexOptions.Compiled);
@@ -77,49 +77,57 @@ public static partial class InflectorExtensions
     public static string Singularize(this string word, bool inputIsKnownToBePlural = true, bool skipSimpleWords = false) =>
         Vocabularies.Default.Singularize(word, inputIsKnownToBePlural, skipSimpleWords);
 
-    /// <summary>
-    /// Humanizes the input with Title casing
-    /// </summary>
-    /// <param name="input">The string to be titleized</param>
-    public static string Titleize(this string input)
-    {
-        var humanized = input.Humanize();
-        // If humanization returns empty string (no recognized letters), preserve original input
-        return humanized.Length == 0 ? input : humanized.ApplyCase(LetterCasing.Title);
-    }
-
-    /// <summary>
-    /// By default, pascalize converts strings to UpperCamelCase also removing underscores
-    /// </summary>
-    public static string Pascalize(this string input) =>
-        PascalizeRegex().Replace(input, match => match
-            .Groups[1]
-            .Value.ToUpper());
-
-    /// <summary>
-    /// Same as Pascalize except that the first character is lower case
-    /// </summary>
-    public static string Camelize(this string input)
+    extension(string input)
     {
-        var word = input.Pascalize();
-        return word.Length > 0
-            ? StringHumanizeExtensions.Concat(
-                char.ToLower(word[0]),
-                word.AsSpan(1))
-            : word;
+        /// <summary>
+        /// Humanizes the input with Title casing
+        /// </summary>
+        public string Titleize()
+        {
+            var humanized = input.Humanize();
+            // If humanization returns empty string (no recognized letters), preserve original input
+            return humanized.Length == 0 ? input : humanized.ApplyCase(LetterCasing.Title);
+        }
+
+        /// <summary>
+        /// By default, pascalize converts strings to UpperCamelCase also removing underscores
+        /// </summary>
+        public string Pascalize() =>
+            PascalizeRegex().Replace(input, match => match
+                .Groups[1]
+                .Value.ToUpper(CultureInfo.CurrentUICulture));
+
+        /// <summary>
+        /// Same as Pascalize except that the first character is lower case
+        /// </summary>
+        public string Camelize()
+        {
+            var word = input.Pascalize();
+            return word.Length > 0
+                ? StringHumanizeExtensions.Concat(
+                    char.ToLower(word[0]),
+                    word.AsSpan(1))
+                : word;
+        }
+
+        /// <summary>
+        /// Separates the input words with underscore
+        /// </summary>
+        public string Underscore() =>
+            UnderscoreRegex3()
+                .Replace(
+                    UnderscoreRegex2().Replace(
+                        UnderscoreRegex1().Replace(input, "$1_$2"), "$1_$2"), "_")
+                .ToLower(CultureInfo.CurrentUICulture);
+
+        /// <summary>
+        /// Separates the input words with hyphens and all the words are converted to lowercase
+        /// </summary>
+        public string Kebaberize() =>
+            Underscore(input)
+                .Dasherize();
     }
 
-    /// <summary>
-    /// Separates the input words with underscore
-    /// </summary>
-    /// <param name="input">The string to be underscored</param>
-    public static string Underscore(this string input) =>
-        UnderscoreRegex3()
-            .Replace(
-                UnderscoreRegex2().Replace(
-                    UnderscoreRegex1().Replace(input, "$1_$2"), "$1_$2"), "_")
-            .ToLower();
-
     /// <summary>
     /// Replaces underscores with dashes in the string
     /// </summary>
@@ -131,11 +139,4 @@ public static string Dasherize(this string underscoredWord) =>
     /// </summary>
     public static string Hyphenate(this string underscoredWord) =>
         Dasherize(underscoredWord);
-
-    /// <summary>
-    /// Separates the input words with hyphens and all the words are converted to lowercase
-    /// </summary>
-    public static string Kebaberize(this string input) =>
-        Underscore(input)
-            .Dasherize();
 }

src/Humanizer/Localisation/Formatters/FrenchFormatter.cs

@@ -1,4 +1,4 @@
-namespace Humanizer;
+namespace Humanizer;
 
 class FrenchFormatter(CultureInfo culture) :
     DefaultFormatter(culture)
@@ -12,7 +12,7 @@ protected override string GetResourceKey(string resourceKey, int number)
             return resourceKey + DualPostfix;
         }
 
-        if (number == 0 && resourceKey.StartsWith("TimeSpanHumanize_Multiple"))
+        if (number == 0 && resourceKey.StartsWith("TimeSpanHumanize_Multiple", StringComparison.InvariantCulture))
         {
             return resourceKey + "_Singular";
         }

src/Humanizer/Localisation/NumberToWords/ArabicNumberToWordsConverter.cs

@@ -265,7 +265,7 @@ static string ParseNumber(string word, int number, GrammaticalGender gender)
         if (number <= 10)
         {
             var ordinals = gender == GrammaticalGender.Feminine ? FeminineOrdinalExceptions : OrdinalExceptions;
-            foreach (var kv in ordinals.Where(kv => word.EndsWith(kv.Key)))
+            foreach (var kv in ordinals.Where(kv => word.EndsWith(kv.Key, StringComparison.OrdinalIgnoreCase)))
             {
                 // replace word with exception
                 return StringHumanizeExtensions.Concat(
@@ -285,7 +285,7 @@ static string ParseNumber(string word, int number, GrammaticalGender gender)
                 var oldPart = part;
 
                 var ordinals = gender == GrammaticalGender.Feminine ? FeminineOrdinalExceptions : OrdinalExceptions;
-                foreach (var kv in ordinals.Where(kv => oldPart.EndsWith(kv.Key)))
+                foreach (var kv in ordinals.Where(kv => oldPart.EndsWith(kv.Key, StringComparison.OrdinalIgnoreCase)))
                 {
                     // replace word with exception
                     newPart = StringHumanizeExtensions.Concat(

src/Humanizer/Localisation/NumberToWords/BrazilianPortugueseNumberToWordsConverter.cs

@@ -11,6 +11,8 @@ class BrazilianPortugueseNumberToWordsConverter :
     static readonly string[] OrdinalTensMap = ["zero", "décimo", "vigésimo", "trigésimo", "quadragésimo", "quinquagésimo", "sexagésimo", "septuagésimo", "octogésimo", "nonagésimo"];
     static readonly string[] OrdinalHundredsMap = ["zero", "centésimo", "ducentésimo", "trecentésimo", "quadringentésimo", "quingentésimo", "sexcentésimo", "septingentésimo", "octingentésimo", "noningentésimo"];
 
+    static readonly CultureInfo Culture = CultureInfo.GetCultureInfo("pt-BR");
+
     public override string Convert(long input, GrammaticalGender gender, bool addAnd = true)
     {
         if (input is > 999999999999 or < -999999999999)
@@ -164,17 +166,17 @@ static string ApplyGender(string toWords, GrammaticalGender gender)
             return toWords;
         }
 
-        if (toWords.EndsWith("os"))
+        if (toWords.EndsWith("os", StringComparison.OrdinalIgnoreCase))
         {
             return StringHumanizeExtensions.Concat(toWords.AsSpan(0, toWords.Length - 2), "as".AsSpan());
         }
 
-        if (toWords.EndsWith("um"))
+        if (toWords.EndsWith("um", StringComparison.OrdinalIgnoreCase))
         {
             return StringHumanizeExtensions.Concat(toWords.AsSpan(0, toWords.Length - 2), "uma".AsSpan());
         }
 
-        if (toWords.EndsWith("dois"))
+        if (toWords.EndsWith("dois", StringComparison.OrdinalIgnoreCase))
         {
             return StringHumanizeExtensions.Concat(toWords.AsSpan(0, toWords.Length - 4), "duas".AsSpan());
         }

src/Humanizer/Localisation/NumberToWords/CentralKurdishNumberToWordsConverter.cs

@@ -68,7 +68,7 @@ public override string Convert(long number)
         }
 
         var sentence = string.Join(" و ", parts);
-        if (sentence.StartsWith("یەک هەزار"))
+        if (sentence.StartsWith("یەک هەزار", StringComparison.OrdinalIgnoreCase))
         {
             return sentence[" یەک".Length..];
         }

src/Humanizer/Localisation/NumberToWords/DutchNumberToWordsConverter.cs

@@ -171,7 +171,7 @@ public override string ConvertToOrdinal(int number)
     {
         var word = Convert(number);
 
-        foreach (var kv in OrdinalExceptions.Where(kv => word.EndsWith(kv.Key)))
+        foreach (var kv in OrdinalExceptions.Where(kv => word.EndsWith(kv.Key, StringComparison.Ordinal)))
         {
             // replace word with exception
             return StringHumanizeExtensions.Concat(word.AsSpan(0, word.Length - kv.Key.Length), kv.Value.AsSpan());

src/Humanizer/Localisation/NumberToWords/FrenchNumberToWordsConverterBase.cs

@@ -4,6 +4,7 @@ abstract class FrenchNumberToWordsConverterBase : GenderedNumberToWordsConverter
 {
     static readonly string[] UnitsMap = ["zéro", "un", "deux", "trois", "quatre", "cinq", "six", "sept", "huit", "neuf", "dix", "onze", "douze", "treize", "quatorze", "quinze", "seize", "dix-sept", "dix-huit", "dix-neuf"];
     static readonly string[] TensMap = ["zéro", "dix", "vingt", "trente", "quarante", "cinquante", "soixante", "septante", "octante", "nonante"];
+    static readonly CultureInfo Culture = CultureInfo.GetCultureInfo("fr");
 
     public override string Convert(long number, GrammaticalGender gender, bool addAnd = true)
     {
@@ -41,20 +42,20 @@ public override string ConvertToOrdinal(int number, GrammaticalGender gender)
 
         var convertedNumber = Convert(number);
 
-        if (convertedNumber.EndsWith('s') && !convertedNumber.EndsWith("trois"))
+        if (convertedNumber.EndsWith('s') && !convertedNumber.EndsWith("trois", true, Culture))
         {
             convertedNumber = convertedNumber.TrimEnd('s');
         }
-        else if (convertedNumber.EndsWith("cinq"))
+        else if (convertedNumber.EndsWith("cinq", true, Culture))
         {
             convertedNumber += "u";
         }
-        else if (convertedNumber.EndsWith("neuf"))
+        else if (convertedNumber.EndsWith("neuf", true, Culture))
         {
             convertedNumber = convertedNumber.TrimEnd('f') + "v";
         }
 
-        if (convertedNumber.StartsWith("un "))
+        if (convertedNumber.StartsWith("un ", true, Culture))
         {
             convertedNumber = convertedNumber[3..];
         }

src/Humanizer/Localisation/NumberToWords/GreekNumberToWordsConverter.cs

@@ -1,4 +1,4 @@
-namespace Humanizer;
+namespace Humanizer;
 
 class GreekNumberToWordsConverter : GenderlessNumberToWordsConverter
 {
@@ -8,6 +8,7 @@ class GreekNumberToWordsConverter : GenderlessNumberToWordsConverter
     static readonly string[] TensNoDiacriticsMap = ["", "δεκα", "εικοσι", "τριαντα", "σαραντα", "πενηντα", "εξηντα", "εβδομηντα", "ογδοντα", "ενενηντα"];
     static readonly string[] HundredMap = ["", "εκατό", "διακόσια", "τριακόσια", "τετρακόσια", "πεντακόσια", "εξακόσια", "επτακόσια", "οκτακόσια", "εννιακόσια"];
     static readonly string[] HundredsMap = ["", "εκατόν", "διακόσιες", "τριακόσιες", "τετρακόσιες", "πεντακόσιες", "εξακόσιες", "επτακόσιες", "οκτακόσιες", "εννιακόσιες"];
+    static readonly CultureInfo Culture = CultureInfo.GetCultureInfo("el");
 
     static readonly FrozenDictionary<long, string> ΟrdinalMap = new Dictionary<long, string>
     {
@@ -265,7 +266,7 @@ string ConvertIntBH(long number, bool returnPluralized)
             }
 
             result += ConvertImpl(number % 10, returnPluralized)
-                .ToLower();
+                .ToLower(Culture);
         }
 
         return result;
@@ -291,7 +292,7 @@ string ConvertIntBT(long number, bool returnPluralized)
 
         if (number % 100 != 0)
         {
-            result += $" {ConvertImpl(number % 100, returnPluralized).ToLower()}";
+            result += $" {ConvertImpl(number % 100, returnPluralized).ToLower(Culture)}";
         }
 
         return result;
@@ -306,14 +307,14 @@ string ConvertIntBM(long number)
                 return "χίλια";
             }
 
-            return $"χίλια {ConvertImpl(number % 1000, false).ToLower()}";
+            return $"χίλια {ConvertImpl(number % 1000, false).ToLower(Culture)}";
         }
 
         var result = $"{ConvertImpl(number / 1000, true)} χιλιάδες";
 
         if (number % 1000 != 0)
         {
-            result += $" {ConvertImpl(number % 1000, false).ToLower()}";
+            result += $" {ConvertImpl(number % 1000, false).ToLower(Culture)}";
         }
 
         return result;
@@ -328,14 +329,14 @@ string ConvertIntBB(long number)
                 return "ένα εκατομμύριο";
             }
 
-            return $"ένα εκατομμύριο {ConvertImpl(number % 1000000, true).ToLower()}";
+            return $"ένα εκατομμύριο {ConvertImpl(number % 1000000, true).ToLower(Culture)}";
         }
 
         var result = $"{ConvertImpl(number / 1000000, false)} εκατομμύρια";
 
         if (number % 1000000 != 0)
         {
-            result += $" {ConvertImpl(number % 1000000, false).ToLower()}";
+            result += $" {ConvertImpl(number % 1000000, false).ToLower(Culture)}";
         }
 
         return result;
@@ -350,16 +351,16 @@ string ConvertIntBTR(long number)
                 return "ένα δισεκατομμύριο";
             }
 
-            return $"ένα δισεκατομμύριο {ConvertImpl(number % 1000000000, true).ToLower()}";
+            return $"ένα δισεκατομμύριο {ConvertImpl(number % 1000000000, true).ToLower(Culture)}";
         }
 
         var result = $"{ConvertImpl(number / 1000000000, false)} δισεκατομμύρια";
 
         if (number % 1000000000 != 0)
         {
-            result += $" {ConvertImpl(number % 1000000000, false).ToLower()}";
+            result += $" {ConvertImpl(number % 1000000000, false).ToLower(Culture)}";
         }
 
         return result;
     }
-}
+}