Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateOnly has current date return 'today' #1186

Closed
behroozbc opened this issue Mar 5, 2022 · 11 comments · May be fixed by #1278
Closed

DateOnly has current date return 'today' #1186

behroozbc opened this issue Mar 5, 2022 · 11 comments · May be fixed by #1278
Labels
enhancement jump in

Comments

@behroozbc
Copy link

When you want to humanize the DateOnly that has current date return 'now'.it's better to return 'today'. 'now' Word referee current date and time but 'today' referee only current date
@hangy
Copy link
Contributor

hangy commented Mar 7, 2022

I agree. Just for completeness:

Humanizer/src/Humanizer.Tests.Shared/DateOnlyHumanizeTests.cs

Line 36 in 937e827

const string expectedResult = "one month from now";

Should this also be "one month from today" instead? The precision is the same as "now" vs. "today".

@behroozbc
Copy link
Author

behroozbc commented Mar 7, 2022 •
edited
Loading

I'm new to contributing to this repository. I found DateOnly behind the scenes using the DateTime algorithm.

Humanizer/src/Humanizer/DateTimeHumanizeStrategy/DateTimeHumanizeAlgorithms.cs

Line 165 in 937e827

return DefaultHumanize(ts, sameMonth, days, tense, culture);

It seems to me DateOnly needs its algorithm.

@louis-z
Copy link
Contributor

louis-z commented Mar 20, 2022

Is anyone already looking into this? If not, I'd be willing to have a go at it.

@behroozbc
Copy link
Author

Is anyone already looking into this? If not, I'd be willing to have a go at it.

Can I help you? I want to learn and know what happened inside of Humanizer.

@hangy hangy mentioned this issue Mar 23, 2022
Closed
@hemalshah28
Copy link

Is anyone already looking into this? Can I try to fix it? Please assign issue

@louis-z
Copy link
Contributor

louis-z commented Nov 1, 2022

Is anyone already looking into this? Can I try to fix it? Please assign issue

I looked at the issue briefly back in March... but my branch has become stale since then. As far as I'm concerned, you can go ahead. 😉

hemalshah28 added a commit to hemalshah28/Humanizer that referenced this issue Nov 1, 2022
@hemalshah28
fixed Issue Humanizr#1186
8cb1ba5
@michaela559
Copy link

Hello, is this fixed or still open?

@behroozbc
Copy link
Author

Hello, is this fixed or still open?

I think you can start and implement a new pull request. In addition, you can use this pull request experience.

hemalshah28 added a commit to hemalshah28/Humanizer that referenced this issue Nov 23, 2022
@hemalshah28
Revert "fixed Issue Humanizr#1186"
492830f 
This reverts commit 8cb1ba5.
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Apr 25, 2023
@AJacksonCT
fixes Humanizr#1186 replacing 'now' with 'today' for all day or longe…
39a6c07 
…r time periods
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Apr 25, 2023
@AJacksonCT
fixes for Humanizr#1186 for other languages
0cf55b1
@AJacksonCT AJacksonCT mentioned this issue Apr 25, 2023
Closed
1 task
@AJacksonCT
Copy link

My first time contributing to a github project, let me know if there is anything else I should do.

AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Jun 7, 2023
@AJacksonCT
Humanizr#1186 fixed failing unit tests
60b0494
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Jun 7, 2023
@AJacksonCT
Humanizr#1186 fixed failing unit tests
b38ca6a
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Jun 7, 2023
@AJacksonCT
fixes Humanizr#1186 replacing 'now' with 'today' for all day or longe…
a7e3e99 
…r time periods
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Jun 7, 2023
@AJacksonCT
fixes for Humanizr#1186 for other languages
2e50589
AJacksonCT added a commit to AJacksonCT/Humanizer that referenced this issue Jun 7, 2023
@AJacksonCT
@AJacksonCT
7f7ee89 
fixes Humanizr#1186 replacing 'now' with 'today' for all day
Updated Failing Tests
@AJacksonCT AJacksonCT mentioned this issue Jun 7, 2023
Open
@AJacksonCT
Copy link

Finally completed a PR that passed. Hopefully, this is acceptable and can be merged

@SimonCropp
Copy link
Collaborator

@ AJacksonCT if you still want this approach, can you re submit as an opt in approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement jump in
Projects
None yet
Milestone
No milestone
8 participants
@hangy @SimonCropp @clairernovotny @AJacksonCT @behroozbc @hemalshah28 @louis-z @michaela559