Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string formatting options to ToQuanity #175

Closed
dealdiane opened this issue Apr 11, 2014 · 3 comments
Closed

Add string formatting options to ToQuanity #175

dealdiane opened this issue Apr 11, 2014 · 3 comments

Comments

@dealdiane
Copy link

Would be nice to add a string format parameter to ToQuantity.

"woman".ToQuantity(12345, "N0") would return "12,345 women". End users prefer to see numbers in a more familiar way.

@dealdiane
Copy link
Author

can't figure out how github works but I forked it and made this commit. Formatting option is only available when showQuantityAs = ShowQuantityAs.Numeric. Format parameter doesn't make sense if the number is converted to words.

dealdiane@6fd29d5

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Nice. I like it. Please create a Pull Request for it. Here is a guide.

Please also write unit tests for it and also add your PR to the release-notes file. Thanks.

@MehdiK
Copy link
Member

MehdiK commented Apr 19, 2014

This was done in #220.

@MehdiK MehdiK closed this as completed Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants