Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEnsembleIssueDates() and getEnsembleStartDates() in the EnsembleDatabase interface #132

Open
ktarbet opened this issue May 31, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ktarbet
Copy link
Collaborator

ktarbet commented May 31, 2022

I feel we should rename getEnsembleIssueDates() to getEnsembleStartDates(). (and return values from the start_datetime column)

getEnsembleStartDates() may be more appropriate for a minimal use case. In the test cases , in the code base, issue_datetime and start_datetime have been equivalent.

With DSS compatibility in mind I'm seeing issue_datetime as a 'version' of the data, that would map to the V tag in a F-part, and start_datetime maps to the T tag.

any thoughts?

@ktarbet ktarbet added the question Further information is requested label May 31, 2022
@HenryGeorgist
Copy link
Member

i think it makes sense to use get start date instead of get issuance date.

Though both are important.

we should add get issuance date, and replace current usage with get start date. but we should do that after current branches have been pruned.

@ktarbet ktarbet added enhancement New feature or request and removed question Further information is requested labels Jun 3, 2022
@ktarbet ktarbet self-assigned this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants