Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return an error indication for invalid /labelValues filter parameters #1780

Closed
willr3 opened this issue Jun 14, 2024 · 1 comment · Fixed by #1977
Closed

return an error indication for invalid /labelValues filter parameters #1780

willr3 opened this issue Jun 14, 2024 · 1 comment · Fixed by #1977
Assignees

Comments

@willr3
Copy link
Collaborator

willr3 commented Jun 14, 2024

Right now an invalid filter to <test>/labelValues returns the full list of labelValues as though filter was not used. This can lead to users incorrectly believing the results reflect the desired filter.

I beleive we should instead return an error to indicate that the provided filter was invalid. This will lead to correct filter usage rather than silently accepting invalid filters.

@lampajr
Copy link
Member

lampajr commented Oct 16, 2024

If I am not wrong, this change was incorporated into #1977, therefore I am closing this one as completed.

Feel free to re-open it if I misunerstood something.

@lampajr lampajr closed this as completed Oct 16, 2024
@lampajr lampajr self-assigned this Oct 16, 2024
@lampajr lampajr linked a pull request Oct 16, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants