Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration tests #11

Open
mehaase opened this issue Feb 13, 2019 · 1 comment
Open

Clean up integration tests #11

mehaase opened this issue Feb 13, 2019 · 1 comment
Labels
refactor Refactoring without changing functionality

Comments

@mehaase
Copy link
Contributor

mehaase commented Feb 13, 2019

At some point while writing tests, I decided to factor out database queries into the starbelly.db module. This allows me to write unit tests of other modules without a database dependency, and then the queries are covered by a series of integration tests. But I didn't have time to update modules/tests that I created before making this decision, such as test_robots.py, test_subscription, login.py, etc. Grep for db_pool—it should only appear in db.py—and refactor modules to not use it.

@mehaase
Copy link
Contributor Author

mehaase commented Feb 28, 2019

Update: I removed test_robots.py while fixing a design flaw in bd25ddb. The robots manager still needs to be updated with a database abstraction layer.

@mehaase mehaase added the refactor Refactoring without changing functionality label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring without changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant