Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and readme out of sync #68

Open
abhinavsinha001 opened this issue Apr 8, 2022 · 0 comments
Open

Code and readme out of sync #68

abhinavsinha001 opened this issue Apr 8, 2022 · 0 comments

Comments

@abhinavsinha001
Copy link

Tried to set this up and run - seems there are lot of refactoring and updates to code parameters which are not reflected in README.

e.g This command doesn’t work

go run examples/signer-server.go --frequency 5s --logtostderr --body '{"sample": "request"}' --origin_callsign=ssai-serving.tk --url='http://ads.ad-exchange.tk:8090/request?param1=example&param2=another' --send_requests

The path and params have changed to

go run examples/signer-server/signer-server.go -frequency 5s --body '{"sample": "request"}' -origin=ssai-serving.tk -url='http://ads.ad-exchange.tk:8090/request?param1=example&param2=another' -send_requests

I will try to fix as much of this as possible and raise a PR. I would request code contributors to please update the readme as well.

Additionally I see there is no working domain with that I can test with
ssai-serving.tk doesn’t work

No record found for _delivery._adscert.ssai.tk in 126.8093ms: lookup _delivery._adscert.ssai-serving.tk on 8.8.8.8:53: no such host
2022/04/09 00:06:16 counterparty lookup error
2022/04/09 00:06:16 SIGNATURE_DECODE_STATUS_COUNTERPARTY_LOOKUP_ERROR

Neither does publica-ssai.com doesn’t work - seems there is private key mismatch

2022/04/09 00:25:09 Found records for _delivery._adscert.publica-ssai.com in 63.009852ms: [v=adcrtd k=x25519 h=sha256 p=StWZV1kkgId0iOAmVLutWhWSv6SGuM-pdavckWrQKXY]
2022/04/09 00:25:21 SIGNATURE_DECODE_STATUS_INVALID_SIGNATURE

Can someone provide steps to get a bare minimum domain and key setup for validating this. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant