Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Should standard versions also be tested against the Version codelist? #125

Closed
dalepotter opened this issue Sep 4, 2017 · 2 comments
Closed

Should standard versions also be tested against the Version codelist? #125

dalepotter opened this issue Sep 4, 2017 · 2 comments
Labels
code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. question A question. versions Relating to IATI Version Numbers.

Comments

@dalepotter
Copy link
Contributor

dalepotter commented Sep 4, 2017 •
edited
Loading

Following the code review comment @hayfield there is a question if tests for iati.core.constants.STANDARD_VERSIONS should also check that they are part of the Version codelist.

However, this may reduce the extensibility of the library will break things for developing the standard for future version upgrades.
@dalepotter dalepotter added the code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. label Sep 4, 2017
@dalepotter dalepotter mentioned this issue Sep 4, 2017
Merged
@hayfield hayfield changed the title Should standard versions should also be tested against the Version codelist Should standard versions also be tested against the Version codelist? Sep 13, 2017
@hayfield hayfield added the question A question. label Sep 13, 2017
@hayfield
Copy link
Contributor

This relates to the question of what the Version codelist should contain, and whether it should be embedded, with a single value at each version.

@hayfield
Copy link
Contributor

The answer to the question in the title (at least at present, in the context of #218 and #223) is: no

@hayfield hayfield added the versions Relating to IATI Version Numbers. label Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. question A question. versions Relating to IATI Version Numbers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayfield @dalepotter