Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome new issue! #13

Open
IAmHughes opened this issue Sep 15, 2020 · 17 comments
Open

Awesome new issue! #13

IAmHughes opened this issue Sep 15, 2020 · 17 comments

Comments

@IAmHughes
Copy link
Owner

IAmHughes commented Sep 15, 2020

This is a bunch of text about what this feature request is.

/giphy just do it

@github-actions
Copy link

send it atlanta braves GIF by MLB

Powered by GIPHY

@github-actions
Copy link

just do it GIF

Powered by GIPHY

@IAmHughes
Copy link
Owner Author

IAmHughes commented Sep 15, 2020

/giphy hacker

@github-actions
Copy link

charlie hunnam yes GIF

Powered by GIPHY

@IAmHughes
Copy link
Owner Author

Whatever information

/giphy bootcamp

@github-actions
Copy link

Powered by GIPHY

@IAmHughes
Copy link
Owner Author

/giphy another one

@github-actions
Copy link

No Sad GIF by Dolly Parton

Powered by GIPHY

@rajbos
Copy link

rajbos commented May 13, 2023

Something seems to be off with the url that is generate, as they are not loading @IAmHughes ?

/giphy roll the dice

@github-actions
Copy link

Rolling Dice Here You Go GIF by Rich The Kid

Powered by GIPHY

@rajbos
Copy link

rajbos commented May 13, 2023

Hmm, seems to be hit or miss:

/giphy scrum agile standup

@github-actions
Copy link

Stand Up Comedy GIF by The Ed Sullivan Show

Powered by GIPHY

@IAmHughes
Copy link
Owner Author

Hmm, seems to be hit or miss:

/giphy scrum agile standup

there may be a bug in that it doesn't find results for the gif and I probably am not handling the error Giphy's API throws. Thank you for the info!

@rajbos
Copy link

rajbos commented May 15, 2023

Did you check the actual markdown being generated? I think I have seen links that should work (might have been a different solution).

I'm also thinking if this could be caused by rate limiting on Giphy's end?

@IAmHughes
Copy link
Owner Author

Did you check the actual markdown being generated? I think I have seen links that should work (might have been a different solution).

I'm also thinking if this could be caused by rate limiting on Giphy's end?

I'm not really sure if it's a rate limit or something else. The markdown looks correct to me where we're seeing blanks here.

To be honest this was a fun sample project of an example of what you can do with Actions outside of just CI/CD type of tooling. I'm totally open to PRs if you find a specific issue and wanted to contribute, but otherwise I unfortunately have it in a bit of an inactive state in terms of updates and such. If time permits, I wouldn't mind coming back to it.

@IAmHughes
Copy link
Owner Author

/giphy ship it

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

internet ship it GIF

Powered by GIPHY

Repository owner deleted a comment from github-actions bot Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants