Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create table uses "contains" instead of exact match #130

Open
sophierm opened this issue May 16, 2022 · 0 comments
Open

Create table uses "contains" instead of exact match #130

sophierm opened this issue May 16, 2022 · 0 comments

Comments

@sophierm
Copy link

Describe the bug
When trying to create a new table, the method searches whether the table is already in the catalog. Here, if the table name is a subset of a table name that is already in the catalog the table creation fails.

To Reproduce
Steps to reproduce the behavior:

  1. Create table "test123"
  2. Create table "test"
    -> no new table is created and the function returns none - nothing happens

Expected behavior
Table creation should work for all table names that do not exactly match a table already in the catalog.
We would expect more meaningful returns: return at least "true" or "false" values and even better, logging the reason why a table creation fails / throw exception.

Screenshots
ibmcloudsql/catalog_table.py
image (29)
line 288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant