Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bm): patch of security groups on bare metal server nics #4504

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

ujjwal-ibm
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #4479

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ujjwal-ibm ujjwal-ibm changed the title fix(bm): parch of security groups on bare metal server nics fix(bm): patch of security groups on bare metal server nics Apr 17, 2023
nicflag = true
}
}
if d.HasChange("primary_network_interface.0.security_groups") && !d.IsNewResource() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesnt require to set nicflag = true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, adding of sg groups is taken care inside this block itself.

@hkantare
Copy link
Collaborator

Can you add test case results

@ujjwal-ibm
Copy link
Collaborator Author

=== RUN   TestAccIBMISBareMetalServer_sg_update
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISBareMetalServer_sg_update (1092.94s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1094.963s

@hkantare hkantare merged commit 218345a into IBM-Cloud:master Apr 19, 2023
@ujjwal-ibm ujjwal-ibm deleted the bm-sg-patch branch April 19, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibm_is_bare_metal_server: change to security groups does not trigger change
2 participants