Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ibm_container_cluster_versions to return current default version #4720

Closed
ocofaigh opened this issue Jul 28, 2023 · 1 comment
Labels
enhancement service/Kubernetes Service Issues related to Kubernetes Service Issues

Comments

@ocofaigh
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be very handy if ibm_container_cluster_versions data lookup could be updated to return the current default version. This can be extracted from the json returned by the api (see default values below):

{
    "kubernetes": [
        {
            "major": 1,
            "minor": 24,
            "patch": 16,
            "default": false,
            "end_of_service": "2023-10-11T23:59:59+0000"
        },
        {
            "major": 1,
            "minor": 25,
            "patch": 12,
            "default": false,
            "end_of_service": ""
        },
        {
            "major": 1,
            "minor": 26,
            "patch": 7,
            "default": true,
            "end_of_service": ""
        },
        {
            "major": 1,
            "minor": 27,
            "patch": 4,
            "default": false,
            "end_of_service": ""
        }
    ],
    "openshift": [
        {
            "major": 4,
            "minor": 9,
            "patch": 59,
            "default": false,
            "end_of_service": "2023-08-30T23:59:59+0000"
        },
        {
            "major": 4,
            "minor": 10,
            "patch": 63,
            "default": false,
            "end_of_service": ""
        },
        {
            "major": 4,
            "minor": 11,
            "patch": 44,
            "default": false,
            "end_of_service": ""
        },
        {
            "major": 4,
            "minor": 12,
            "patch": 24,
            "default": true,
            "end_of_service": ""
        },
        {
            "major": 4,
            "minor": 13,
            "patch": 5,
            "default": false,
            "end_of_service": ""
        }
    ]
}

In the UI the default version shows as the recommended version:
image

New or Affected Resource(s)

  • ibm_container_cluster_versions

Potential Terraform Configuration

default_ocp_version = "${data.ibm_container_cluster_versions.cluster_versions.default_openshift_version}_openshift"
default_kube_version = "${data.ibm_container_cluster_versions.cluster_versions.default_kube_version}"

References

  • #0000
@ocofaigh
Copy link
Contributor Author

this has been implemented as part of #4799 - nice work @akocbek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement service/Kubernetes Service Issues related to Kubernetes Service Issues
Projects
None yet
Development

No branches or pull requests

1 participant