Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

feat: enable iOS sdk generation after invoking model generator #260

Merged
merged 7 commits into from
Jul 20, 2017
Merged

feat: enable iOS sdk generation after invoking model generator #260

merged 7 commits into from
Jul 20, 2017

Conversation

tfrank64
Copy link
Contributor

I might need to lengthen the timeout on model generator tests, but I haven't had any issues thus far.

@tfrank64 tfrank64 self-assigned this Jul 17, 2017
@tunniclm tunniclm changed the title feat: enabled iOS sdk generation after invoking model generator feat: enable iOS sdk generation after invoking model generator Jul 18, 2017
tunniclm
tunniclm reviewed Jul 18, 2017
View reviewed changes
refresh/index.js
this.itemsToIgnore[item]
)
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the above block, I'm trying to see when this might be needed. Can you help me understand the flow that introduces new entries in this.itemsToIgnore after the .gitignore file is written? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunniclm Well I first noticed it in the integration tests that multiple references to an iOS SDK were being added to the .gitignore. It can also happen with multiple runs of the yo swiftserver:model command, which is possible right now, but maybe not encouraged, not sure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Makes total sense. It is absolutely fine to run the model generator multiple times.

@codecov-io
Copy link

codecov-io commented Jul 19, 2017 •
edited
Loading

Codecov Report

Merging #260 into develop will decrease coverage by 0.04%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #260      +/-   ##
=========================================
- Coverage    90.04%    90%   -0.05%     
=========================================
  Files           11     11              
  Lines         1236   1240       +4     
=========================================
+ Hits          1113   1116       +3     
- Misses         123    124       +1
Impacted Files Coverage Δ
app/index.js 91.74% <100%> (-0.06%) ⬇️
refresh/index.js 91.39% <88.88%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611599f...1b641da. Read the comment docs.

@tfrank64 tfrank64 merged commit f27a770 into develop Jul 20, 2017
@tfrank64 tfrank64 deleted the sdkgen_model_flow branch July 20, 2017 19:37
@tunniclm tunniclm added this to the 2.6.1 milestone Jul 21, 2017
tunniclm added a commit that referenced this pull request Jul 27, 2017
@tunniclm
Merge pull request #271 from IBM-Swift/updateTo2.7.0
c2738e7 
Release 2.7.0

### Features

* decouple swaggerize ([ead4636](ead4636))
* enable iOS sdk generation after invoking model generator ([#260](#260)) ([f27a770](f27a770))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tunniclm tunniclm tunniclm approved these changes

Assignees

@tfrank64 tfrank64

Labels
enhancement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tfrank64 @codecov-io @tunniclm