This repository was archived by the owner on Feb 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
fix: Failing generator-swiftserver integration tests for SDKGen service #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunniclm
approved these changes
Jan 4, 2018
Codecov Report
@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
+ Coverage 89.96% 90.61% +0.64%
===========================================
Files 9 9
Lines 1286 1278 -8
===========================================
+ Hits 1157 1158 +1
+ Misses 129 120 -9
Continue to review full report at Codecov.
|
tunniclm
approved these changes
Jan 5, 2018
tunniclm
suggested changes
Jan 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked the package-lock.json and it contains invalid merge marks (I think!)
The file should be re-generated to fix.
tunniclm
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #544
Changes
Note In the readPackageDependencies method, we had a test to verify the package url from the sdkgen service matched our expectations (i.e. there was a minor version). Since we already had this logic, I added a similar regex expression. It is not strictly necessary, so we could remove it and its associated test case.
The regex looks for properly formatted package urls using the
.upToNextMajor
,.upToNextMinor
,from:
syntax ( does not support.branch
). It also requires properly formatted version strings of a standard x.x.x format.Exit Criteria