Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

fix(unsupported services): added tests for unsupported service payloads #431

Merged
merged 2 commits into from
Jan 21, 2018

Conversation

dingwilson
Copy link
Contributor

Adds tests to check for unwanted behavior when given unsupported service payloads from custom bluemix string

@dingwilson dingwilson requested a review from EnriqueL8 January 16, 2018 15:04
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if test pass , @tunniclm want to have a look?

@codecov-io
Copy link

codecov-io commented Jan 19, 2018

Codecov Report

Merging #431 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #431      +/-   ##
===========================================
+ Coverage    90.82%   90.89%   +0.07%     
===========================================
  Files            9        9              
  Lines         1329     1329              
===========================================
+ Hits          1207     1208       +1     
+ Misses         122      121       -1
Impacted Files Coverage Δ
lib/helpers.js 94.33% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae501e...0ce1608. Read the comment docs.

@dingwilson dingwilson merged commit b3e1870 into develop Jan 21, 2018
tunniclm added a commit that referenced this pull request Jan 26, 2018
Release 4.4.0

### Bug Fixes

* **package:** update generator-ibm-cloud-enablement to version 0.6.13 ([#416](#416)) ([13a14f5](13a14f5))
* **package:** update generator-ibm-service-enablement to version 0.6.5 ([#423](#423)) ([6769e0b](6769e0b))
* make RouteTests more lenient on index content ([#427](#427)) ([1ae501e](1ae501e))
* **unsupported services:** added tests to check for unwanted behavior when given unsupported service payloads from custom bluemix string ([#431](#431)) ([b3e1870](b3e1870))
* use correct redis default port ([#433](#433)) ([623f206](623f206))


### Features

* model support for swagger ([#422](#422)) ([9cb8438](9cb8438))
@dingwilson dingwilson deleted the unsupportedServicePayloads branch February 6, 2018 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants