Skip to content
This repository was archived by the owner on Feb 28, 2020. It is now read-only.

fixed init special chars #445

Merged
merged 1 commit into from
Feb 7, 2018
Merged

fixed init special chars #445

merged 1 commit into from
Feb 7, 2018

Conversation

Andrew-Lees11
Copy link
Member

Fix for issue #437.
The init option was no handling hyphen in project name correctly. The generator was using the yoman name for the init option which replaces all special characters with spaces. This is different from our generator which replaces special characters with dashes.

I have moved the generate project name above the init spec so that the name is generated and then used for the init. I have also made the init function create a new directory if the name is changed.

These changes with make the init function act the same as accepting all default parameters when going through yo swiftserver.

I have also added some extra special characters to be replaced with dashes for the name function and corrected the comments.

A test for this fix has added and all npm tests are passing.

@codecov-io
Copy link

codecov-io commented Feb 5, 2018

Codecov Report

Merging #445 into develop will increase coverage by <.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #445      +/-   ##
===========================================
+ Coverage    90.93%   90.94%   +<.01%     
===========================================
  Files            9        9              
  Lines         1335     1336       +1     
===========================================
+ Hits          1214     1215       +1     
  Misses         121      121
Impacted Files Coverage Δ
app/index.js 91.15% <100%> (+0.02%) ⬆️
lib/helpers.js 94.33% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dad7fe...b2a69e7. Read the comment docs.

@tunniclm tunniclm merged commit ca255f1 into IBM-Swift:develop Feb 7, 2018
tunniclm added a commit that referenced this pull request Feb 7, 2018
Release 4.5.1

### Bug Fixes

* Init special chars bug ([#445](#445)) ([ca255f1](ca255f1))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants