Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting search parameters messages should note the full URL of the conflict code #1885

Closed
d0roppe opened this issue Jan 25, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request P2 Priority 2 - Should Have search

Comments

@d0roppe
Copy link
Collaborator

d0roppe commented Jan 25, 2021

Is your feature request related to a problem? Please describe.
When a message of conflicting search parameters is issued, it would be good to know the full URL of the code so you can more easily code up the filter to disambiguate the conflict.

Example of current message:
00000035 com.ibm.fhir.search.util.SearchUtil W Skipping search parameter with id='location-address'. Found multiple search parameters for code 'address' on resource type 'Location'; use search parameter filtering to disambiguate.

Describe the solution you'd like
would like to know full URL of the conflicting searchparameters. Not just the one conflicting with what is already loaded, but all of them.

Acceptance Criteria
1.
GIVEN: Starting the FHIR server with conflicting search parameters from the base and optional IG's loaded
THEN look in the log file to verify the messages have the FULL URL's of the options listed.

@prb112 prb112 added enhancement New feature or request search labels Feb 1, 2021
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Mar 11, 2021
@tbieste tbieste self-assigned this May 3, 2021
@tbieste tbieste added this to the Sprint 2021-06 milestone May 3, 2021
tbieste added a commit that referenced this issue May 3, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
prb112 added a commit that referenced this issue May 7, 2021
Issue #1885 - Include search parameter URLs in conflict warning message
@tbieste
Copy link
Contributor

tbieste commented May 10, 2021

During QA testing, Dag noticed another related code path:

[5/10/21, 17:51:28:054 UTC] 0000004c com.ibm.fhir.search.util.SearchUtil W Found multiple resource-specific search parameters for code ‘name’ on resource type Patient; use search parameter filtering to disambiguate. Using ‘http://hl7.org/fhir/SearchParameter/Patient-name’.

tbieste added a commit that referenced this issue May 10, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue May 13, 2021
Issue #1885 - Include search parameter URLs in conflict warning message
@d0roppe
Copy link
Collaborator Author

d0roppe commented May 13, 2021

Verified new messages

[5/13/21, 16:27:15:784 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Skipping search parameter with id='explanationofbenefit-identifier'. Found multiple search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-identifier' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-identifier', for code 'identifier' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate.
[5/13/21, 16:27:15:784 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Skipping search parameter with id='explanationofbenefit-provider'. Found multiple search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-provider' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-provider', for code 'provider' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate.
[5/13/21, 16:27:15:784 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Skipping search parameter with id='explanationofbenefit-patient'. Found multiple search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-patient' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-patient', for code 'patient' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate.
[5/13/21, 16:27:15:785 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Skipping search parameter with id='explanationofbenefit-care-team'. Found multiple search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-care-team' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-care-team', for code 'care-team' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate.
[5/13/21, 16:27:15:785 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Skipping search parameter with id='explanationofbenefit-coverage'. Found multiple search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-coverage' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-coverage', for code 'coverage' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate.
[5/13/21, 16:27:15:835 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Found multiple resource-specific search parameters, 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-care-team' and 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-care-team', for code 'care-team' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate. Using 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-care-team'.
[5/13/21, 16:27:15:835 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Found multiple resource-specific search parameters, 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-provider' and 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-provider', for code 'provider' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate. Using 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-provider'.
[5/13/21, 16:27:15:835 UTC] 00000039 com.ibm.fhir.search.util.SearchUtil                          W Found multiple resource-specific search parameters, 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-patient' and 'http://hl7.org/fhir/SearchParameter/ExplanationOfBenefit-patient', for code 'patient' on resource type 'ExplanationOfBenefit'; use search parameter filtering to disambiguate. Using 'http://hl7.org/fhir/us/carin-bb/SearchParameter/explanationofbenefit-patient'.

@d0roppe d0roppe closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority 2 - Should Have search
Projects
None yet
Development

No branches or pull requests

4 participants