Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File-based export writes empty files #2121

Closed
lmsurpre opened this issue Mar 22, 2021 · 1 comment
Closed

File-based export writes empty files #2121

lmsurpre opened this issue Mar 22, 2021 · 1 comment
Assignees
@lmsurpre
Labels
bug Something isn't working
Milestone
Sprint 2021-04

Comments

@lmsurpre
Copy link
Member

Describe the bug
We added a check that prevents our S3-based export from writing empty files.
However, for file-based export, we still write the file even when there are no resources to write.

To Reproduce

  1. invoke a file-based $export on a fresh db (no resources)
  2. check the output directory

Expected behavior
Only resource types with one or more resource will have files in the export.

Additional context
N/A
@lmsurpre lmsurpre added the bug Something isn't working label Mar 22, 2021
@lmsurpre lmsurpre self-assigned this Mar 22, 2021
lmsurpre added a commit that referenced this issue Mar 22, 2021
@lmsurpre
issue #2121 - skip file creation when the buffer is empty
f0469da 
Also, set more status fields in transient user data (chunkData) to
facilitate logging / debug.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 22, 2021
@lmsurpre
issue #2121 - skip file creation when the buffer is empty
8c7454a 
Also, set more status fields in transient user data (chunkData) to
facilitate logging / debug.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre added this to the Sprint 2021-04 milestone Mar 22, 2021
lmsurpre added a commit that referenced this issue Mar 22, 2021
@lmsurpre
issue #2121 - skip file creation when the buffer is empty
14b134b 
Also, set more status fields in transient user data (chunkData) to
facilitate logging / debug.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 22, 2021
@lmsurpre
issue #2121 - skip file creation when the buffer is empty
015a36f 
Also, set more status fields in transient user data (chunkData) to
facilitate logging / debug.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 22, 2021
@lmsurpre
issue #2121 - skip file creation when the buffer is empty
3a59944 
Also, set more status fields in transient user data (chunkData) to
facilitate logging / debug.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112 added a commit that referenced this issue Mar 22, 2021
@prb112
Merge pull request #2122 from IBM/issue-2094
40cf470 
issue #2121 - skip file creation when the buffer is empty
@d0roppe
Copy link
Collaborator

d0roppe commented Mar 23, 2021

Verified that only export files with 1 or more resources are created for all 3 types of exports. Closing issue.

@d0roppe d0roppe closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 2021-04
Development

No branches or pull requests
2 participants
@lmsurpre @d0roppe