Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fhir-model code subtype nested classes from ValueSet to Value #2169

Closed
lmsurpre opened this issue Mar 29, 2021 · 1 comment
Closed
Assignees
Labels
deprecation enhancement New feature or request

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Mar 29, 2021

Is your feature request related to a problem? Please describe.

When we first designed the fhir-model classes for R4, we decided to model Code types with a required binding in the base spec as their own classes that extend Code and the bound valueset as a nested class called ValueSet.

However, as I've been working with these enums more and more, the name ValueSet has started to bug me.
Each enum value is like an instance of the Enum and so there is some dissonance when we define a member like this:
MyCode.ValueSet myVal;

Because myVal is actually a specific value for MyCode, not its ValueSet.

Describe the solution you'd like

  1. Add a peer to the nested ValueSet classes and override functions as necessary to make the values equivalent to the existing ValueSet values.
  2. Deprecate the old ValueSet classes and remove all references to these throughout the codebase.
  3. After a couple releases, remove the old ValueSet classes; probably in combination with the introduce of support for Support for R4B #2068

Describe alternatives you've considered
live with the ValueSet name for these nested classes

Acceptance Criteria

Additional context

@prb112 prb112 added the enhancement New feature or request label Mar 29, 2021
@lmsurpre lmsurpre self-assigned this Apr 25, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-06 milestone Apr 25, 2021
lmsurpre added a commit that referenced this issue Apr 25, 2021
For all code subtypes.

Also updated Binding and Maturity annotations to use the new enum
values.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 25, 2021
For all code subtypes.

Also updated Binding and Maturity annotations to use the new enum
values.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 28, 2021
And convert from for loop to a switch.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 28, 2021
…oject code (#2293)

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@kmbarton423
Copy link
Contributor

No additional verification needs to be done with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants