-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fhir-model code subtype nested classes from ValueSet to Value #2169
Comments
lmsurpre
added a commit
that referenced
this issue
Apr 25, 2021
For all code subtypes. Also updated Binding and Maturity annotations to use the new enum values. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 25, 2021
For all code subtypes. Also updated Binding and Maturity annotations to use the new enum values. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 27, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 28, 2021
And convert from for loop to a switch. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 28, 2021
…oject code (#2293) Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
No additional verification needs to be done with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When we first designed the
fhir-model
classes for R4, we decided to model Code types with a required binding in the base spec as their own classes that extend Code and the bound valueset as a nested class called ValueSet.However, as I've been working with these enums more and more, the name
ValueSet
has started to bug me.Each enum value is like an instance of the Enum and so there is some dissonance when we define a member like this:
MyCode.ValueSet myVal;
Because myVal is actually a specific value for MyCode, not its ValueSet.
Describe the solution you'd like
Describe alternatives you've considered
live with the ValueSet name for these nested classes
Acceptance Criteria
Additional context
The text was updated successfully, but these errors were encountered: