-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fhirServer/search/useStoredCompartmentParam
#2886
Labels
configuration
deprecation
documentation
Improvements or additions to documentation
removal
this change involves removal of a component, class, method, etc
technical debt
Comments
possibly a duplicate of #1777 ? |
lmsurpre
changed the title
Deprecate and remove
Deprecate Nov 8, 2021
fhirServer/search/useStoredCompartmentParam
fhirServer/search/useStoredCompartmentParam
will require updates to both user guide and conformance.md |
lmsurpre
added a commit
that referenced
this issue
Mar 8, 2022
This compatibility config property is from 4.5.1 and its time to remove this optionality from the code. Also updated tests and docs. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Mar 8, 2022
This compatibility config property is from 4.5.1 and its time to remove this optionality from the code. Also updated tests and docs. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Mar 8, 2022
issue #2886 - remove useStoredCompartmentParam property
lmsurpre
changed the title
Deprecate
Remove Mar 14, 2022
fhirServer/search/useStoredCompartmentParam
fhirServer/search/useStoredCompartmentParam
QA should be done together with #1777 |
lmsurpre
added
the
removal
this change involves removal of a component, class, method, etc
label
Mar 14, 2022
verified that the use of this config parameter is not honored. Closing issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
configuration
deprecation
documentation
Improvements or additions to documentation
removal
this change involves removal of a component, class, method, etc
technical debt
Is your feature request related to a problem? Please describe.
This parameter was introduced about a year ago (IBM FHIR Server 4.5.1) as a compatibility mechanism for smooth migrations.
I'm hoping that we can deprecate it now and maybe remove it at some point in the future.
We don't have a rule for how long we keep these backwards-compatibility properties around, so this issue can be our placeholder/reminder.
Describe the solution you'd like
Deprecate
fhirServer/search/useStoredCompartmentParam
now.Remove it in a few releases.
Describe alternatives you've considered
Leave it around forever
Acceptance Criteria
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
We have a couple places in the code-base that branch on this config value. It will be nice to remove the stale branches.
I'm not even 100% confident that the stale branches still function as expected now that we've rewritten most of the query builder.
The text was updated successfully, but these errors were encountered: