-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification Service operationType should match Audit action #2988
Comments
Relates to #2471, specifically the comment at #2967 (comment) Its potentially broader than just the notification message, because the notifications are emitted from the PersistenceEvent via our FHIRPersistenceInterceptor framework. So, as indicated in that comment, the key thing is deciding whether we want to treat an "undelete" like a create from start to finish (i.e. call |
|
for number 3, our current history impl shows a response status of "200 OK" in the undelete case. |
Verified that now a resource that has been deleted and then the ID is used again, the fhir-server reports it as a create. |
Is your feature request related to a problem? Please describe.
For the Notification Service: the operationType should match Audit action. So when a resource has been deleted, and then the same ID is used again for a create. the operationType should be create and not update.
Describe the solution you'd like
So if the resource has been deleted and then you create a new resource with the same ID, it is a create. not an update.
Describe alternatives you've considered
So there is another way of looking at this. And in the users guide it states that there are only 2 valid values for operationType, Create and Update. if you only use those two, then I would say if the resource ID has never been used before then it is a create and all subsequent uses are updates. But currently the delete of a resource has a operationType of delete.
So maybe need a separate issue for this but will leave it here if only create and update are valid for operationType:
If delete is valid for the operationType, the Users guide should be updated (section 4.2.1). And the delete entry in the Notification Service should include the /_history/ of the resource to match the create and update operationType.
The text was updated successfully, but these errors were encountered: