Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from FHIRPersistence interface #3158

Closed
lmsurpre opened this issue Jan 6, 2022 · 3 comments
Closed

Remove deprecated methods from FHIRPersistence interface #3158

lmsurpre opened this issue Jan 6, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Jan 6, 2022

Is your feature request related to a problem? Please describe.
To avoid unnecessary java API breakage in 4.x, we deprecated create, update, delete, and maybe others from this interface. We replaced them with createWithMeta, updateWithMeta, deleteWithMeta variants and changed the contract slightly: the PL will no longer make any updates to the resource content.

Describe the solution you'd like
Remove the deprecated flavor of these methods

Describe alternatives you've considered

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Should we change the names back to create, update, and delete in the process?

@lmsurpre
Copy link
Member Author

Should we change the names back to create, update, and delete in the process?

team decision: change back to the simpler names and document it in release notes as a breaking java api change for 5.0

@lmsurpre lmsurpre added P2 Priority 2 - Should Have documentation Improvements or additions to documentation labels Jan 26, 2022
@lmsurpre
Copy link
Member Author

need to update the "Bring your own Persistence Guide"

@punktilious punktilious self-assigned this Feb 1, 2022
punktilious added a commit that referenced this issue Feb 2, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 3, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 4, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 4, 2022
issue #3158 remove deprecated methods from FHIRPersistence
@lmsurpre
Copy link
Member Author

The deprecated methods have been removed and the "withMeta" options are now renamed to the simpler "create", "update", "delete"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

2 participants