Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous reporting of Pending Outcome in Audit #3204

Closed
prb112 opened this issue Jan 18, 2022 · 1 comment
Closed

Erroneous reporting of Pending Outcome in Audit #3204

prb112 opened this issue Jan 18, 2022 · 1 comment
Assignees
@prb112
Labels
audit bug Something isn't working

Comments

@prb112
Copy link
Contributor

prb112 commented Jan 18, 2022

Describe the bug
A clear and concise description of what the bug is.

Erroneous reporting of Pending Outcome in Audit

https://github.com/IBM/FHIR/blame/4.4.0/fhir-audit/src/main/java/com/ibm/fhir/audit/logging/impl/WhcAuditCadfLogService.java
59ec08d

            if (logEntry.getContext().getEndTime() == null ||
                    logEntry.getContext().getStartTime().equalsIgnoreCase(logEntry.getContext().getEndTime())) {
                cadfEventOutCome = Outcome.pending;

Environment
Which version of IBM FHIR Server? main / 4.1.0.2

To Reproduce
Steps to reproduce the behavior:

  1. Go to curl --request DELETE
    --url https://localhost:9443/fhir-server/api/v4/Patien/DollarEverythingTest-Patient01
    --header ‘Authorization: Basic BLAH’
    --header ‘Content-Type: application/json’
    --header ‘x-fhir-tenant-id: 4196’
  2. Check the Audit

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@prb112 prb112 added bug Something isn't working audit labels Jan 18, 2022
@prb112 prb112 self-assigned this Jan 18, 2022
prb112 added a commit that referenced this issue Jan 18, 2022
@prb112
Erroneous reporting of Pending Outcome in Audit #3204
3b61a87 
- Timing of start/end leads to Outcome.pending to be reported
- It should be success/failure rather then pending

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Jan 18, 2022
@prb112
Merge pull request #3205 from IBM/issue-3204
6812422 
Erroneous reporting of Pending Outcome in Audit #3204
@prb112
Copy link
Contributor Author

prb112 commented Jan 26, 2022

Michelle confirmed offline. QA complete.

@prb112 prb112 closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
audit bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prb112