Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value set 'http://hl7.org/fhir/us/core/ValueSet/us-core-usps-state' is empty or could not be expanded #3270

Closed
lmsurpre opened this issue Feb 2, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Feb 2, 2022

Is your feature request related to a problem? Please describe.
In the US Core IG, they have a ValueSet for US Postal Service states: http://hl7.org/fhir/us/core/STU4/ValueSet-us-core-usps-state.json.html

Unfortunately, the codesystem they pull from isn't defined in FHIR:

  "compose" : {
    "include" : [
      {
        "system" : "https://www.usps.com/"
      }
    ]
  }

Our current validation will therefor result in the following warning:

    {
        "severity": "warning",
        "code": "incomplete",
        "expression": ["Patient.address[0].state"],
        "details": {"text": "Membership check was not performed: value set 'http://hl7.org/fhir/us/core/ValueSet/us-core-usps-state' is empty or could not be expanded"}
    }

Describe the solution you'd like
An expanded version of this valueset available in the registry so that we can use it to validate

Describe alternatives you've considered
document how to use the remote term service provider for this codesystem

Acceptance Criteria

  1. GIVEN our us-core jar is in userlib
    AND a patient resource that claims conformance to us-core-patient and has an address with a state element that has a code from http://hl7.org/fhir/us/core/ValueSet/us-core-usps-state'
    WHEN you create/update (with Prefer: return=OperationOutcome) or $validate the resource
    THEN there are no informational or warning issues about being unable to validate the code

  2. GIVEN our us-core jar is in userlib
    AND a patient resource that claims conformance to us-core-patient and has an address with a state element that has a value which is not from http://hl7.org/fhir/us/core/ValueSet/us-core-usps-state'
    WHEN you create/update (with Prefer: return=OperationOutcome) or $validate the resource
    THEN there is an informational issue about being unable to validate the code

Additional context

@lmsurpre lmsurpre added the enhancement New feature or request label Feb 2, 2022
@lmsurpre
Copy link
Member Author

consider looking to package a set of pre-expanded valuesets because there are other valuesets like 'http://hl7.org/fhir/us/core/STU4/ValueSet-us-core-condition-code.html' that are even more complicated to expand (requires SNOMED CT support)

@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Mar 28, 2022
lmsurpre added a commit that referenced this issue Mar 28, 2022
The ValueSet in US Core does not include the actual codes. Rather than
add a CodeSystem resource for the codes, we replace the packaged
ValueSet with a pre-expanded version that lists all the codes.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre self-assigned this Mar 28, 2022
lmsurpre added a commit that referenced this issue Mar 30, 2022
issue #3270 - package expanded us-core-usps-state ValueSet
@d0roppe
Copy link
Collaborator

d0roppe commented Apr 3, 2022

Verified that this now does not issue any warning if you use a valid USPS Code for the state

@d0roppe d0roppe closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

2 participants