Avoid use of injected httpHeaders and uriInfo when in client mode #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to allow fhir-provider to execute in other environments such as from within a standalone RestEasy client. Also converted the static 'isPretty' helper to a member function to allow access to the instance-level RuntimeType. Also added javadoc to help distinguish FHIRProvider from FHIRJsonProvider. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
LGTM - I had to read the isPretty method directly at https://github.com/IBM/FHIR/blob/d97ff4d16feafddd54dfc6025fdd49ead4a1b9a9/fhir-provider/src/main/java/com/ibm/fhir/provider/FHIRProvider.java#L140
Also, it makes sense given the use-case described.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to allow fhir-provider to execute in other
environments such as from within a standalone RestEasy client.
I also converted the static 'isPretty' helper to a member function to
allow access to the instance-level RuntimeType.
I also added javadoc to help distinguish FHIRProvider from
FHIRJsonProvider.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com