Issue #2424 - add support for non-validating builders / parsers

[JohnTimm]

Changes made:

• Updated the AbstractBuilder class to include a validating field, a setValidating method, and an isValidating method
• Updated the FHIRAbstractParser class to include a validating field, a setValidating method, and an isValidating method
• Updated the FHIRJsonParser.isPropertySupported method to return super.isPropertySupported(name)
• Updated the FHIRParser interface to expose setValidating and isValidating methods
• Moved all calls to the ValidationSupport utility class outside of the constructor into a new generated validate method on the respective nested builder class.
  NOTE: This decision was made after taking another look at Effective Java, the Google Protobuf Java library, the javapoet Java library, and this Stack Overflow:
  https://stackoverflow.com/questions/38173274/builder-pattern-validation-effective-java
  Specifically the mention of this quote from Effective Java:

It is critical that they be checked after copying the parameters from the builder to the object, and that they be checked on the object fields rather than the builder fields (Item 39). If any invariants are violated, the build method should throw an IllegalStateException (Item 60).

Example of the new generated validate method:

protected void validate(Account account) {
    super.validate(account);
    ValidationSupport.checkList(account.identifier, "identifier", Identifier.class);
    ValidationSupport.requireNonNull(account.status, "status");
    ValidationSupport.checkList(account.subject, "subject", Reference.class);
    ValidationSupport.checkList(account.coverage, "coverage", Coverage.class);
    ValidationSupport.checkList(account.guarantor, "guarantor", Guarantor.class);
    ValidationSupport.checkReferenceType(account.subject, "subject", "Patient", "Device", "Practitioner", "PractitionerRole", "Location", "HealthcareService", "Organization");
    ValidationSupport.checkReferenceType(account.owner, "owner", "Organization");
    ValidationSupport.checkReferenceType(account.partOf, "partOf", "Account");
}

• Added call to new validate method from the build method (guarded by validating field):

public Account build() {
    Account account = new Account(this);
    if (validating) {
        validate(account);
    }
    return account;
}

• Re-generated Json and XML parser to pass the value of their validating field to the AbstractBuilder.setValidating method immediately after the builder class is instantiated (using the builder static factory method). For example:

private Account parseAccount(...) {
    //...<snip>
    Account.Builder builder = Account.builder();
    builder.setValidating(validating);
    //...<snip>
    return builder.build();
}

• Added generated from method to generated Code subtypes to be consistent with generated model classes
• Updated FHIRPersistenceJDBCImpl.convertResourceDTO method to use FHIRParser.setValidating(false) so that resources read from the database do not use a "validating" parser.
• Updated FHIRParserBenchmark to include benchmarks for both validating and non-validating Json and XML parsers.

Here are the results after running the updated benchmark with 5 random spec examples:

operationdefinition-example
Benchmark                                                     Mode  Cnt      Score      Error  Units
FHIRParserBenchmark.benchmarkJsonParser                      thrpt    4   6999.749 ±  743.366  ops/s
FHIRParserBenchmark.benchmarkJsonParserNonValidating         thrpt    4  19261.375 ± 4047.486  ops/s
FHIRParserBenchmark.benchmarkXMLParser                       thrpt    4   4727.621 ±  701.067  ops/s
FHIRParserBenchmark.benchmarkXMLParserNonValidating          thrpt    4   8174.837 ± 1010.988  ops/s

library-zika-virus-intervention-logic
Benchmark                                                     Mode  Cnt      Score      Error  Units
FHIRParserBenchmark.benchmarkJsonParser                      thrpt    4   8561.627 ±  765.289  ops/s
FHIRParserBenchmark.benchmarkJsonParserNonValidating         thrpt    4  11228.661 ±  914.804  ops/s
FHIRParserBenchmark.benchmarkXMLParser                       thrpt    4   6474.798 ±  823.414  ops/s
FHIRParserBenchmark.benchmarkXMLParserNonValidating          thrpt    4   7531.063 ± 2309.640  ops/s

detectedissue-example-dup
Benchmark                                                     Mode  Cnt      Score       Error  Units
FHIRParserBenchmark.benchmarkJsonParser                      thrpt    4  17946.689 ±  3762.102  ops/s
FHIRParserBenchmark.benchmarkJsonParserNonValidating         thrpt    4  41626.245 ±  4491.693  ops/s
FHIRParserBenchmark.benchmarkXMLParser                       thrpt    4  11651.696 ±   370.050  ops/s
FHIRParserBenchmark.benchmarkXMLParserNonValidating          thrpt    4  19683.286 ± 10744.125  ops/s

careplan-example-f002-lung
Benchmark                                                     Mode  Cnt      Score      Error  Units
FHIRParserBenchmark.benchmarkJsonParser                      thrpt    4   7267.189 ± 4378.650  ops/s
FHIRParserBenchmark.benchmarkJsonParserNonValidating         thrpt    4  18340.629 ± 6584.793  ops/s
FHIRParserBenchmark.benchmarkXMLParser                       thrpt    4   5744.205 ± 2573.052  ops/s
FHIRParserBenchmark.benchmarkXMLParserNonValidating          thrpt    4  10407.999 ± 3061.489  ops/s

encounter-example-emerg
Benchmark                                                     Mode  Cnt      Score      Error  Units
FHIRParserBenchmark.benchmarkJsonParser                      thrpt    4  11601.736 ± 1988.297  ops/s
FHIRParserBenchmark.benchmarkJsonParserNonValidating         thrpt    4  15088.933 ± 2637.177  ops/s
FHIRParserBenchmark.benchmarkXMLParser                       thrpt    4   8221.663 ± 1575.012  ops/s
FHIRParserBenchmark.benchmarkXMLParserNonValidating          thrpt    4  10661.899 ± 1101.927  ops/s

As you can see, there is a very tangible performance boost when using non-validating parsers for both Json and XML.

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

[prb112]

LGTM - reviewed with John on WebEx

[lmsurpre]

LGTM