Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle angular wrapper components using angular package format #115

Merged
merged 8 commits into from
Dec 3, 2018

Conversation

theiliad
Copy link
Member

@theiliad theiliad commented Nov 30, 2018

Closes #114

Updates

  • Use ng-packagr to bundle angular wrapper components
  • Add width & height as component inputs
  • Merge angular demo project with the angular package

@netlify
Copy link

netlify bot commented Nov 30, 2018

Deploy preview for carbon-charts ready!

Built with commit 7a8fffc

https://deploy-preview-115--carbon-charts.netlify.com

@netlify
Copy link

netlify bot commented Nov 30, 2018

Deploy preview for carbon-charts ready!

Built with commit c17fd0c

https://deploy-preview-115--carbon-charts.netlify.com

Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in the next PR pls

"check-type"
]
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at the end of file.

Suggested change
}
}

@zvonimirfras zvonimirfras merged commit 68c2df1 into carbon-design-system:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants