Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The x-axis labels go out of the boundary after re-rendering #121

Closed
1 task done
arnajdas92 opened this issue Jan 2, 2019 · 7 comments
Closed
1 task done

The x-axis labels go out of the boundary after re-rendering #121

arnajdas92 opened this issue Jan 2, 2019 · 7 comments
Assignees

Comments

@arnajdas92
Copy link

arnajdas92 commented Jan 2, 2019

I am submitting a...

  • Design defect

charts version:

0.7.11

Issue description

The x-axis labels go out of the boundary after re-rendering. As visible in the screenshots, the x-axis labels at first wrap around properly. But after the graph re-renders they go out of border.

Screenshot or recording

screenshot 2019-01-02 at 2 23 35 pm

screenshot 2019-01-02 at 2 23 45 pm

@theiliad theiliad self-assigned this Jan 3, 2019
@t-mullen
Copy link
Contributor

t-mullen commented Jan 22, 2019

This breaks since we rerender the chart in a transition - which removes all the formatting on tick values we do.

@theiliad Can you explain why we do .call(xAxis) here? Moving it out of the transition fixes this issue. https://github.com/carbon-design-system/carbon-charts/blob/master/packages/core/src/base-axis-chart.ts#L219

@theiliad
Copy link
Member

@t-mullen Thanks for pointing out the issue. I'll get back to you

@theiliad
Copy link
Member

As far as I remember, you would have to use .call to make sure new axis elements will be added

@kalai001
Copy link

@theiliad , Another related observation. The text in the graph doesn't wrap in the initial rendering also, if the graph is loaded with default width and height. Ideally, the text wrapping be should be determined on the availability of break characters (space).

@pjena98
Copy link

pjena98 commented Jun 20, 2019

We are waiting for a fix and request ETA

@theiliad
Copy link
Member

@pjena98 It's tough to figure out a solution that wouldn't cover the chart.

We've handed off the issue to the design team to come up with a solution. You'll hear back soon

@theiliad
Copy link
Member

theiliad commented Jan 8, 2020

This was addressed in #275

@theiliad theiliad closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants