Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move react and react-dom to peerDependencies #217

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Move react and react-dom to peerDependencies #217

merged 4 commits into from
Mar 20, 2019

Conversation

adamrybinski
Copy link
Contributor

Updates

#216

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@netlify
Copy link

netlify bot commented Mar 20, 2019 •
edited
Loading

Deploy preview for carbon-charts ready!

Built with commit fe0ff95

https://deploy-preview-217--carbon-charts.netlify.com

cal-smith
cal-smith suggested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add ^ to the packages in peerDependencies and add react and react-dom with fixed versions to devDependencies - then we'll be good to go!

cal-smith
cal-smith approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🙌

cal-smith
cal-smith suggested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, almost perfect! lerna/npm doesn't like dangling commas

cal-smith
cal-smith suggested changes Mar 20, 2019
View reviewed changes
packages/react/package.json Outdated Show resolved Hide resolved
@cal-smith
Apply suggestions from code review
fe0ff95 
Co-Authored-By: arybinski <adam@rybinski.info>
@cal-smith cal-smith merged commit e1d0b36 into carbon-design-system:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cal-smith cal-smith cal-smith approved these changes

@theiliad theiliad Awaiting requested review from theiliad theiliad is a code owner

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrybinski @cal-smith