Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UIShell): export ref for all shell components #297

Merged
merged 3 commits into from
Oct 1, 2020
Merged

feat(UIShell): export ref for all shell components #297

merged 3 commits into from
Oct 1, 2020

Conversation

josefaidt
Copy link
Contributor

fixes #296

Description

  • Adds ref to all shell components
/**
   * Obtain a reference to the HTML button element
   * @type {null | HTMLButtonElement} [ref=null]
   */
  export let ref = null;
  • bound to components via
bind:this={ref}

@josefaidt josefaidt requested a review from metonym October 1, 2020 20:15
metonym
metonym reviewed Oct 1, 2020
View reviewed changes
src/UIShell/HeaderGlobalAction.svelte
@@ -20,7 +20,7 @@

<button
type="button"
ref="{ref}"
bind:this="{ref}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes

metonym
metonym approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josefaidt

@metonym metonym merged commit 24888f2 into carbon-design-system:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(UIShell): Export ref for UIShell components
2 participants
@josefaidt @metonym