Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Relax release rules so MICRO version (0.0.X) can be increased for transforms inpdendent of library/runtime #639

Open
2 tasks done
touma-I opened this issue Sep 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@touma-I
Copy link
Collaborator

touma-I commented Sep 29, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Other

Feature

The current release process increments the MICRO version for both transforms and library. Given the high rate of changes to the transforms, this process adds overhead an unnecessary churn by forcing us to increment the release number for the library each time we want to create a release cutoff for the transforms. We propose decoupling the two by:

  • Allow a new release of the transforms to increment the transform MICRO number(..X) while keeping the library MICRO number the same (..Y) with Y <= X
  • When a minor release for the transforms and library is needed, increment the MINOR number and reset the MICRO to 0 before appending the devN suffix (_.X.0.dev0)

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@touma-I touma-I added the enhancement New feature or request label Sep 29, 2024
@touma-I touma-I assigned touma-I and daw3rd and unassigned touma-I Oct 1, 2024
@daw3rd
Copy link
Member

daw3rd commented Oct 1, 2024

With the above in mind, we have the following:

Guiding principals/goals

  1. github "releases" will be published to a new minor (not micro) version number. For example, 0.3.0
  2. when there is a github release, we will publish pypi wheels and images
  3. transforms can increment the micro version independently of the core library version and formal github release
  4. We will (for now) keep the dev suffix, until we decide we can live w/o it.
  5. It is ok and expected to republish a transform at a new minor version that may be the same functionally as the previous version (i.e 0.3.0 and 0.2.9)
  6. Transforms can define dependencies on DPK in pypi or in the repo source (choice is already supported today via USE_REPO_LIB_SRC in .make.defaults)

TODOs:

  1. Transform version numbers need to be pushed down from .make.versions to a transform-specific location (i.e. transforms/noop/version)
  2. make set-versions neeeds to still work through the repo to reset to a new minor version (i.e. 0.3.0) (and be extended to work on transform's version file)
  3. Update release-branch.sh script to bump minor version numbers instead of micro.
  4. Update RELEASE.md to capture these goals and changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants