Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On slow machines the default connect timeout of 200ms hits when using SSL handshakes. The user does not get any error message in those cases #130

Open
rainerschoe opened this issue Feb 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rainerschoe
Copy link
Member

rainerschoe commented Feb 4, 2022

Slow machine (s390x emulated in QEMU):

bad case:

# gwhisper --ssl --clientCert={$build}/cert-key-pair/client_crt.pem --clientKey={$build}/cert-key-pair/client_key.pem --serverCert={$build}/cert-key-pair/server_crt.pem kaas:60443
Parse failed.Parsed until: '--ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443'
Possible Candidates:
  '--connectTimeoutMilliseconds=200 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 '

good case when manually setting connect timeout

# gwhisper --connectTimeoutMilliseconds=5000 --ssl --clientCert={$build}/cert-key-pair/client_crt.pem --clientKey={$build}/cert-key-pair/client_key.pem --serverCert={$build}/cert-key-pair/server_crt.pem kaas:60443
Parse failed.Parsed until: '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443'
Possible Candidates:
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 examples.ScalarTypeRpcs '
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 examples.NestedTypeRpcs '
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 examples.ComplexTypeRpcs '
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 examples.StreamingRpcs '
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 examples.StatusHandling '
  '--connectTimeoutMilliseconds=5000 --ssl --clientCert=//cert-key-pair/client_crt.pem --clientKey=//cert-key-pair/client_key.pem --serverCert=//cert-key-pair/server_crt.pem kaas:60443 grpc.reflection.v1alpha.ServerReflection '

I did not print an error message in connect timeout scenarios, in order not to confuse tab completion. Tab completion is also the reason, why the default timeout is rather small (to not introduce high wait time if user presses tab on wrong hostname etc.).

Maybe we have to check if we are in tab complete --complete and then print or not print error message

@rainerschoe rainerschoe added the bug Something isn't working label Feb 4, 2022
@rainerschoe rainerschoe changed the title On slow machines the default connect timeout of 200ms hits when using SSL handshakes. The used does not get any error message in those cases On slow machines the default connect timeout of 200ms hits when using SSL handshakes. The user does not get any error message in those cases Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant