Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade axios and re-enable gzipping responses #110

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Sep 22, 2020

I spent some time today reading through the axios docs and issue and I think it should be fine to upgrade to the latest version (0.20.0). It seems to be much more actively maintained than it has been the past year or so, which makes me more comfortable about upgrading. There seem to have been a couple of unintentional breaking changes in this version but neither of them affect us because of how we're using the library in our code.

In addition to this version bump, I added the gzip encoding on responses back in, which was waiting on a fix within axios.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jorge-ibm jorge-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpopp07 dpopp07 merged commit 9e94251 into master Sep 25, 2020
@dpopp07 dpopp07 deleted the dp/update-axios branch September 25, 2020 16:48
ibm-devx-automation pushed a commit that referenced this pull request Sep 25, 2020
# [2.6.0](v2.5.0...v2.6.0) (2020-09-25)

### Features

* upgrade axios and re-enable gzipping responses ([#110](#110)) ([9e94251](9e94251))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants