fix(build): main migration #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Changes look good, but I have one more. While reviewing the PR, I was curious why no changes were needed to the .travis.yml file and discovered that we have this as part of the "deploy" stage:
repo: IBM/node-sdk-core
Please change this line to be:
branch: main
Discussed this with @dpopp07 and we both agree on this change. Not sure why we were using the "repo" setting to begin with :)
Edit: oh, one more thing... can you please change your commit message to something like:
fix(build): main migration
the "fix" type will cause a new patch level, which means we'll exercise the semantic release step with the branch name change, etc.
dpopp07
approved these changes
Feb 10, 2021
christiancompton
force-pushed
the
main-support
branch
from
b22625e to
95f1fbd
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Feb 10, 2021
## [2.7.2](v2.7.1...v2.7.2) (2021-02-10) ### Bug Fixes * **build:** main migration ([#121](#121)) ([1919510](1919510))
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the automation and documentation to support the new
maindefault branch.