fix: persist enableGzipCompression setting on the base service
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new `BaseService` instance is created, the class settings are stored in an object called `baseOptions`. Currently, when the `setEnableGzipCompression` method is called, the `enableGzipCompression` setting is not changed and might no longer reflect the state of the setting (because it is primarily tracked in the underlying `RequestWrapper` class). This PR addresses this by persisting the setting in the `baseOptions` object when that method is called so that the object always reflects the accurate value for the setting.
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 12, 2021
## [2.8.2](v2.8.1...v2.8.2) (2021-03-12) ### Bug Fixes * persist `enableGzipCompression` setting on the base service ([#127](#127)) ([1398044](1398044))
|
🎉 This PR is included in version 2.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new
BaseServiceinstance is created, the class settings are stored in an objectcalled
baseOptions. Currently, when thesetEnableGzipCompressionmethod is called,the
enableGzipCompressionsetting is not changed and might no longer reflect the stateof the setting (because it is primarily tracked in the underlying
RequestWrapperclass).This PR addresses this by persisting the setting in the
baseOptionsobject when that methodis called so that the object always reflects the accurate value for the setting.