Add getQueryParam utility method to support pagination #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
approved these changes
Mar 12, 2021
| * @throws if urlStr is an invalid URL | ||
| */ | ||
| export function getQueryParam(urlStr: string, param: string): string { | ||
| const url = new URL(urlStr, 'https://foo.bar'); |
There was a problem hiding this comment.
Do you mind adding a comment explaining that 'https://foo.bar' is there to support relative URLs? Maybe this is more common than I realize but I've never seen that pattern and I was a little confused. Upon looking it up it made perfect sense but a comment may be helpful for future people
There was a problem hiding this comment.
Good suggestion! I will add a comment.
| it('should return the first value when the query string has duplicate parameters', function() { | ||
| const nextUrl = '/api/v1/offerings?start=foo&start=bar&limit=10'; | ||
| expect(getQueryParam(nextUrl, 'start')).toBe('foo'); | ||
| }); |
mkistler
force-pushed
the
mdk/pagination-methods
branch
from
c4783cd to
0b6552e
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 13, 2021
# [2.10.0](v2.9.0...v2.10.0) (2021-03-13) ### Features * add getQueryParam utility method to support pagination ([#128](#128)) ([d4f067a](d4f067a))
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small utility method to extract the value of a query parameter from a URL string. This will be used in the pagination support for Node.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)