fix: enable symbolic-link credentials files #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, credentials files are explicitly required to real files (not symbolic links). This was to exclude directories, not to exclude symbolic links, so it is a bug. This PR adds explicit support for symbolic links. This should be a robust solution, as I do not believe we want to support any of the other types the file could be (sockets, block devices, etc).
dpopp07
force-pushed
the
dp/enable-symbolic-links
branch
from
830374d to
1225dd0
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 16, 2021
## [2.10.1](v2.10.0...v2.10.1) (2021-03-16) ### Bug Fixes * enable symbolic-link credentials files ([#129](#129)) ([4b87d42](4b87d42))
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, credentials files are explicitly required to real files (not symbolic links).
This was to exclude directories, not to exclude symbolic links, so it is a bug.
This PR adds explicit support for symbolic links. This should be a robust solution, as
I do not believe we want to support any of the other types the file could be (sockets,
block devices, etc).