Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade package-lock.json #136

Merged
merged 1 commit into from
May 10, 2021
Merged

fix: upgrade package-lock.json #136

merged 1 commit into from
May 10, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 7, 2021

This PR updates package-lock.json back to v2 (npm v7.x). Otherwise, there shouldn't be any actual changes to dependency versions. An npm audit run in my local sandbox yielded 0 vulnerabilities (knock on wood!).

@padamstx padamstx self-assigned this May 7, 2021
@padamstx padamstx requested a review from dpopp07 May 7, 2021 22:00
@padamstx
Copy link
Member Author

padamstx commented May 7, 2021

btw, I used a "fix" commit in order to trigger a new patch level. I thought that would be good since Christian's previous change fixed some vulnerabilities.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

I'm honestly not 100% sure what difference it makes to use one version of the lockfile vs the other but I'm fine to keep things at their latest version

@padamstx padamstx merged commit 1780894 into main May 10, 2021
@padamstx padamstx deleted the update-lockfile branch May 10, 2021 14:22
ibm-devx-sdk pushed a commit that referenced this pull request May 10, 2021
## [2.10.4](v2.10.3...v2.10.4) (2021-05-10)

### Bug Fixes

* upgrade package-lock.json ([#136](#136)) ([1780894](1780894))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants