feat: allow IAM clientid/secret to be configured #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 95.38% 95.57% +0.19%
==========================================
Files 7 7
Lines 325 339 +14
Branches 54 55 +1
==========================================
+ Hits 310 324 +14
Misses 13 13
Partials 2 2
Continue to review full report at Codecov.
|
dpopp07
requested changes
Apr 19, 2019
There was a problem hiding this comment.
The changes looks great and the tests are very thorough, so thanks!
I hate to do this to you, but there are a couple style issues that I requested changes on. Want to keep all the code consistent 😅 I guess we're not running the linter in Travis, I'll make that change later
dpopp07
pushed a commit
that referenced
this pull request
Apr 19, 2019
# [0.2.0](v0.1.2...v0.2.0) (2019-04-19) ### Features * allow IAM clientid/secret to be configured ([#14](#14)) ([ff8f2e7](ff8f2e7))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JurajNyiri
pushed a commit
to JurajNyiri/node-sdk-core
that referenced
this pull request
Aug 22, 2024
Generated SDK source code using: - Generator version 3.12.2 - Specification version 0.0.26 - Automation (cloudant-sdks) version 536c0f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/851
This PR includes these changes: