Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): revert inadvertently-committed directories #147

Merged
merged 3 commits into from
Jun 14, 2021
Merged

fix(build): revert inadvertently-committed directories #147

merged 3 commits into from
Jun 14, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jun 14, 2021 •
edited
Loading

This PR contains the following changes:

  • it reverts a recent commit that inadvertently committed the coverage, dist, and node_modules directories
  • temporarily removes the generation and publishing of jsdocs until we can figure out the correct course of action
  • bumps the version of normalize-url package to avoid a high-severity vulnerability

PS: Wow, my PR is removing 3.3M lines :)

@padamstx padamstx requested a review from dpopp07 June 14, 2021 03:44
@padamstx padamstx self-assigned this Jun 14, 2021
@padamstx padamstx changed the title revert docs fix(build): revert inadvertently-committed directories Jun 14, 2021
@padamstx padamstx mentioned this pull request Jun 14, 2021
Closed
dpopp07
dpopp07 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for jumping on this so quickly

@padamstx padamstx merged commit 1fb6295 into main Jun 14, 2021
@padamstx padamstx deleted the revert-docs branch June 14, 2021 14:43
ibm-devx-sdk pushed a commit that referenced this pull request Jun 14, 2021
@semantic-release-bot
chore(release): 2.11.3 [skip ci]
a092012 
## [2.11.3](v2.11.2...v2.11.3) (2021-06-14)

### Bug Fixes

* **build:** revert inadvertently-committed directories ([#147](#147)) ([1fb6295](1fb6295))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

JurajNyiri pushed a commit to JurajNyiri/node-sdk-core that referenced this pull request Aug 22, 2024
@cloudant-sdks-automation
ci: Update generated source code (IBM#147)
f9e66b2 
Generated SDK source code using:
- Generator version 3.24.0
- Specification version 1.0.0-dev0.0.30
- Automation (cloudant-sdks) version e1f9e11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @ibm-devx-sdk @dpopp07