Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method getHttpClient to get underlying axios instance of base service #155

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Aug 17, 2021

This new method is added to the base service class so that all initialized SDK client objects
have access to the underlying axios instance used to make requests. This instance is currently
hidden as a private class member. This functionality is already supported in the other language
cores, so this brings feature parity

…base service

This new method is added to the base service class so that all initialized SDK client objects
have access to the underlying axios instance used to make requests. This instance is currently
hidden as a private class member. This functionality is already supported in the other language
cores, so this brings feature parity
Copy link
Contributor

@barrett-schonefeld barrett-schonefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpopp07 dpopp07 merged commit 2aede01 into main Aug 18, 2021
@dpopp07 dpopp07 deleted the dp/expose-http-client branch August 18, 2021 14:27
ibm-devx-sdk pushed a commit that referenced this pull request Aug 18, 2021
# [2.13.0](v2.12.2...v2.13.0) (2021-08-18)

### Features

* add method `getHttpClient` to get underlying axios instance of base service ([#155](#155)) ([2aede01](2aede01))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants