Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use npm8 and package-lock v2 #186

Merged
merged 1 commit into from
Jan 5, 2022
Merged

build: use npm8 and package-lock v2 #186

merged 1 commit into from
Jan 5, 2022

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jan 4, 2022

This PR migrates the package-lock.json file to v2 and modifies travis.yml to use npm v8 during the travis build.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@padamstx padamstx requested a review from dpopp07 January 4, 2022 23:40
@padamstx padamstx force-pushed the use-npm8 branch 2 times, most recently from ca3c1ed to ecc1859 Compare January 5, 2022 15:57
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to keep the package.json changes but I suppose it's harmless either way. Looks good! 👍

@padamstx
Copy link
Member Author

padamstx commented Jan 5, 2022

I don't think you need to keep the package.json changes but I suppose it's harmless either way. Looks good! +1

Good catch... I guess if we were to ever move the package to be scoped, then we already have that in place :)

@padamstx padamstx merged commit 6b1122c into main Jan 5, 2022
@padamstx padamstx deleted the use-npm8 branch January 5, 2022 20:10
ibm-devx-sdk pushed a commit that referenced this pull request Jan 5, 2022
## [2.17.6](v2.17.5...v2.17.6) (2022-01-05)

### Bug Fixes

* use npm8 and package-lock v2 ([#186](#186)) ([6b1122c](6b1122c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.17.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@padamstx padamstx self-assigned this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants