Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not retry on 501 #197

Merged
merged 3 commits into from
May 2, 2022
Merged

fix: do not retry on 501 #197

merged 3 commits into from
May 2, 2022

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Apr 28, 2022

The other SDK cores skip retry for 501,
so the Node core should behave the same way.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included

The other SDK cores skip retry for 501,
so the Node core should behave the same way.
@pyrooka pyrooka requested a review from padamstx April 28, 2022 14:09
@pyrooka
Copy link
Member Author

pyrooka commented Apr 28, 2022

@padamstx What happened to Travis?

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjasghar
Copy link
Member

jjasghar commented Apr 28, 2022

@pyrooka

What happened to Travis?

We are working on it, not sure what happened, but updates when we have them.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@padamstx padamstx self-assigned this Apr 28, 2022
@padamstx padamstx force-pushed the update-retry-config branch from a20e5e8 to abad001 Compare April 29, 2022 17:30
@pyrooka pyrooka force-pushed the update-retry-config branch from 66f76f8 to 903e649 Compare May 2, 2022 13:28
@pyrooka pyrooka merged commit 5cb9081 into main May 2, 2022
@pyrooka pyrooka deleted the update-retry-config branch May 2, 2022 14:50
ibm-devx-sdk pushed a commit that referenced this pull request May 2, 2022
## [2.17.14](v2.17.13...v2.17.14) (2022-05-02)

### Bug Fixes

* do not retry on 501 ([#197](#197)) ([5cb9081](5cb9081))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.17.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants