-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not retry on 501 #197
Conversation
The other SDK cores skip retry for 501, so the Node core should behave the same way.
@padamstx What happened to Travis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are working on it, not sure what happened, but updates when we have them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
a20e5e8
to
abad001
Compare
66f76f8
to
903e649
Compare
## [2.17.14](v2.17.13...v2.17.14) (2022-05-02) ### Bug Fixes * do not retry on 501 ([#197](#197)) ([5cb9081](5cb9081))
🎉 This PR is included in version 2.17.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
The other SDK cores skip retry for
501
,so the Node core should behave the same way.
Checklist
npm test
passes (tip:npm run lint-fix
can correct most style issues)