Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh dependencies and address import cycles #244

Merged
merged 1 commit into from
May 22, 2023

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 17, 2023

This commit refreshes the project's dependencies to address a high-sev vulnerability reported in the http-cache-semantics package.

Also included in this commit are minor changes to several .ts files in order to address eslint errors reported by the "import/no-cycle" rule. These errors started showing up because the eslint-plugin-import package was also upgraded from 2.26.0 to 2.27.5 (the latest) as a result of refreshing the dependencies.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@padamstx padamstx self-assigned this May 17, 2023
@padamstx padamstx requested a review from dpopp07 May 17, 2023 22:47
@padamstx padamstx force-pushed the fix-import-cycles branch from 5de3033 to 9dc989e Compare May 18, 2023 13:44
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

This commit refreshes the project's dependencies to address
a high-sev vulnerability reported in the http-cache-semantics
package.

Also included in this commit are minor changes to several
.ts files in order to address eslint errors reported by the
"import/no-cycle" rule.  These errors started showing up because
the eslint-plugin-import package was also upgraded from
2.26.0 to 2.27.5 (the latest) as a result of refreshing
the dependencies.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx force-pushed the fix-import-cycles branch from 9dc989e to 36b6863 Compare May 22, 2023 20:45
@padamstx padamstx merged commit 72aa8d5 into main May 22, 2023
@padamstx padamstx deleted the fix-import-cycles branch May 22, 2023 20:48
ibm-devx-sdk pushed a commit that referenced this pull request May 22, 2023
## [4.0.8](v4.0.7...v4.0.8) (2023-05-22)

### Bug Fixes

* refresh dependencies and address import cycles ([#244](#244)) ([72aa8d5](72aa8d5))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants