Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused dependencies #246

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: remove unused dependencies #246

merged 1 commit into from
Jun 22, 2023

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jun 22, 2023

This PR simply removes a few unused dependencies so that we can avoid unnecessary vulnerabilities.

Fixes: #245

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@padamstx padamstx requested a review from dpopp07 June 22, 2023 15:15
@padamstx padamstx self-assigned this Jun 22, 2023
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx changed the title build: remove semver dependency to avoid vulnerability build: remove unused dependencies Jun 22, 2023
@padamstx padamstx requested a review from pyrooka June 22, 2023 15:52
@padamstx padamstx changed the title build: remove unused dependencies fix: remove unused dependencies Jun 22, 2023
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for going through all of those

@padamstx padamstx merged commit 3885ef0 into main Jun 22, 2023
@padamstx padamstx deleted the remove-semver branch June 22, 2023 16:33
ibm-devx-sdk pushed a commit that referenced this pull request Jun 22, 2023
## [4.0.9](v4.0.8...v4.0.9) (2023-06-22)

### Bug Fixes

* remove unused dependencies ([#246](#246)) ([3885ef0](3885ef0))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 4.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2022-25883 on the semver module used in the package
4 participants