Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove node request objects from detailed response #25

Merged
merged 1 commit into from
May 24, 2019

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented May 24, 2019

This will prevent the circular JSON error when attempting to stringify the detailed response. The detailed response will include the status code, the status, the headers, and the data.

This will prevent the circular JSON error when attempting to stringify the detailed response
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #25 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   96.16%   96.18%   +0.01%     
==========================================
  Files           7        7              
  Lines         417      419       +2     
  Branches      124      124              
==========================================
+ Hits          401      403       +2     
  Misses         15       15              
  Partials        1        1
Impacted Files Coverage Δ
lib/requestwrapper.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a525b0...9ac5673. Read the comment docs.

@germanattanasio germanattanasio merged commit 192d8cf into master May 24, 2019
dpopp07 pushed a commit that referenced this pull request May 24, 2019
## [0.2.7](v0.2.6...v0.2.7) (2019-05-24)

### Bug Fixes

* remove node request objects from detailed response ([9ac5673](9ac5673))
* remove node request objects from detailed response ([#25](#25)) ([192d8cf](192d8cf))
@dpopp07
Copy link
Member Author

dpopp07 commented May 24, 2019

🎉 This PR is included in version 0.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dpopp07 dpopp07 deleted the construct-response branch May 24, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants