feat: send user-agent header with auth token requests #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
force-pushed
the
auth-user-agent
branch
2 times, most recently
from
2997880 to
92babfb
Compare
dpopp07
approved these changes
Apr 17, 2024
padamstx
force-pushed
the
auth-user-agent
branch
from
92babfb to
c1e3649
Compare
pyrooka
approved these changes
Apr 17, 2024
This commit updates our various request-based authenticators so that the User-Agent header is included with each outbound token request. The value of the User-Agent header will be of the form "ibm-node-sdk-core/<authenticator-type>-<core-version> <os-info>". Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx
force-pushed
the
auth-user-agent
branch
from
c1e3649 to
4aaeecc
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Apr 17, 2024
# [4.3.0](v4.2.5...v4.3.0) (2024-04-17) ### Features * send user-agent header with auth token requests ([#272](#272)) ([a558274](a558274))
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates our various request-based authenticators so that the User-Agent header is included with each outbound token request. The value of the User-Agent header will be of the form
ibm-node-sdk-core/<authenticator-type>-<core-version> <os-info>.Edit: I also updated
BaseService.createRequest()so that it will add a default User-Agent header to the outbound request if one was not passed in with the request options.Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)