Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): improve node core's debug logging #286

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Aug 23, 2024

This commit adds some debug logging in various components.

Edit: it also includes a more custom logger for http request/response messages

@padamstx padamstx self-assigned this Aug 23, 2024
@padamstx padamstx force-pushed the debug-logging branch 2 times, most recently from c7621cd to f7a435d Compare August 27, 2024 21:29
@padamstx padamstx marked this pull request as ready for review August 27, 2024 21:47
@padamstx padamstx requested review from dpopp07 and pyrooka August 27, 2024 21:47
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I really like the request-wrapper related changes. :)

lib/private-helpers.ts Show resolved Hide resolved
lib/request-wrapper.ts Outdated Show resolved Hide resolved
test/unit/vpc-instance-token-manager.test.js Outdated Show resolved Hide resolved
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

test/unit/redact-secrets.test.js Show resolved Hide resolved
@padamstx padamstx force-pushed the debug-logging branch 2 times, most recently from 3d73293 to 16768c4 Compare August 29, 2024 22:40
This commit includes the following changes:
1. some additional debug logging in various components
2. HTTP message tracing was improved by adding specific
   interceptors to display request/response messages much
   the same way the Go and Java cores do.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx merged commit 7bcb404 into main Sep 3, 2024
4 checks passed
@padamstx padamstx deleted the debug-logging branch September 3, 2024 16:04
ibm-devx-sdk pushed a commit that referenced this pull request Sep 3, 2024
## [5.0.2](v5.0.1...v5.0.2) (2024-09-03)

### Bug Fixes

* **logging:** improve node core's debug logging ([#286](#286)) ([7bcb404](7bcb404))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants